forked from swiss-ai/nanotron
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional validation loop #6
Open
TJ-Solergibert
wants to merge
25
commits into
swiss-ai:main
Choose a base branch
from
TJ-Solergibert:validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-distributed inference
GPT-3 and XGLM implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I push a little fix to disable the validation loop. As we discussed in the last meeting, the parser is not able to differentiate between
NanosetDatasetsArgs
&MultilingualNanosetDatasetsArgs
properly.You can deactivate the validation loop by NOT setting
validation_folder
or by manually settingval_check_interval = -1
.The parser is a bit stupid and won't be able to parse properly as
MultilingualNanosetDatasetsArgs
when specifyingtraining_folder
&validation_folder
, so we will never raise this error. Instead, it will raise the typical parser error which looks like this:Nevertheless, despite raising the parser error instead of the other one complaining about the missing
languages
the functionality is the desired one.PD: Why I'm pushing so many commits? Aren't merged yet? Do they come from the future?